This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] Enable ILP32 mode on aarch64 (version 2)
- From: Steve Ellcey <sellcey at caviumnetworks dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: <libc-alpha at sourceware dot org>, Yury Norov <ynorov at caviumnetworks dot com>
- Date: Wed, 7 Dec 2016 09:05:34 -0800
- Subject: Re: [PATCH 2/2] Enable ILP32 mode on aarch64 (version 2)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <1481060942.29811.41.camel@caviumnetworks.com> <mvm8trshs75.fsf@hawking.suse.de>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Wed, 2016-12-07 at 12:52 +0100, Andreas Schwab wrote:
> >
> > +#define STATFS_IS_STATFS64 1
> This is a lie. You are using .../generic/bits/statfs.h, which assumes
> that fsblkcnt64_t == 2* fsblkcnt_t (etc.), but ILP32 wants them to be
> the same.
So it looks like there are two choices, change STATFS_IS_STATFS64 to
__STATFS_IS_STATFS64 so that I can use it to
ifdef generic/bits/statfs.h without polluting the namespace or
introduce a new aarch64/bits/statfs.h header to use instead of
generic/bits/statfs.h. Is there a preference one way or the other?
My inclination is to create a new header file.
Steve Ellcey
sellcey@caviumnetworks.com