This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Warnings while compiling


>>>>> Jeff Bailey writes:

Jeff> eps/ieee754 -I../sysdeps/libm-ieee754 -I../sysdeps/generic/elf -I../sysdeps/generic    -include ../include/libc-symbols.h  -DPIC   -o /space/home/jbailey/build.glibc/stdlib/strtof_l.os
Jeff> In file included from strtod.c:69,
Jeff>                  from strtof.c:22,
Jeff>                  from strtof_l.c:29:
Jeff> longlong.h:1172: warning: `UDIV_TIME' redefined
Jeff> longlong.h:1170: warning: this is the location of the previous definition

Jeff> I managed to catch this whizzing by on the X window.

Jeff> The offending code from stdlib/longlong.h is:

Jeff> 1170: #define UDIV_TIME (3+7*32)      /* 7 instructions/iteration. 32 iterations. */

Jeff> 1172: #define UDIV_TIME 140

Jeff> Unlike, unfortunetly the Great God drepper, I run screaming from
Jeff> assembler so haven't a clue what's right for this section.  I'll
Jeff> continue to beat on things that I know how to read.

In this case it was the "Great God miller" who introduced the
assembler code:
1998-09-25  David S. Miller  <davem@pierdol.cobaltmicro.com>

        * stdlib/longlong.h (sparc udiv_qrnnd): Define inline version for
        cpus lacking hardware multiply and divide.

The patch introduced line 1170 but didn't remove 1172.  I'm appending
a patch.

Andreas

1998-12-31  Andreas Jaeger  <aj@arthur.rhein-neckar.de>

	* stdlib/longlong.h: Remove extra occurence of UDIV_TIME for
	sparc.

--- stdlib/longlong.h.~1~	Tue Sep 29 21:29:45 1998
+++ stdlib/longlong.h	Thu Dec 31 08:04:28 1998
@@ -1169,7 +1169,6 @@
 	     "0" ((USItype)(n0)) : "%g1" __AND_CLOBBER_CC)
 #define UDIV_TIME (3+7*32)	/* 7 instructions/iteration. 32 iterations. */
 extern USItype __udiv_qrnnd __P ((USItype *, USItype, USItype, USItype));
-#define UDIV_TIME 140
 #endif /* udiv_qrnnd */
 #endif /* __sparc__ */
 


-- 
 Andreas Jaeger   aj@arthur.rhein-neckar.de    jaeger@informatik.uni-kl.de
  for pgp-key finger ajaeger@aixd1.rhrk.uni-kl.de


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]