This is the mail archive of the
libc-hacker@cygnus.com
mailing list for the glibc project.
[Bug 2546] Changed - statvfs() implementation in glibc-2.1 is broken
- To: dkl@redhat.com, elias@hi.is
- Subject: [Bug 2546] Changed - statvfs() implementation in glibc-2.1 is broken
- From: bugzilla@redhat.com
- Date: Fri, 7 May 1999 07:49:08 -0400
http://developer.redhat.com/bugzilla/show_bug.cgi?id=2546
--- shadow/2546 Thu May 6 16:09:18 1999
+++ shadow/2546.tmp.21768 Fri May 7 07:49:07 1999
@@ -11,7 +11,7 @@
AssignedTo: dkl@redhat.com
ReportedBy: elias@hi.is
URL:
-Cc: bugzilla-owner@redhat.com
+Cc: maage@cs.tut.fi, gafton@redhat.com, hjl@gnu.org, bugzilla-owner@redhat.com
Summary: statvfs() implementation in glibc-2.1 is broken
A recently implemented statvfs()in glibc-2.1 is
@@ -46,3 +46,29 @@
exit(0);
}
+
+------- Additional Comments From elias@hi.is 05/07/99 07:49 -------
+The problem seems to be resulting from the glibc-2.11-fstatvfs.patch
+Is this patch really necessary at all?
+
+The offending parts of the patch (originally submitted from
+hjl@gnu.org to gafton@redhat.com):
+
+diff -u -p -r1.1.1.4 fstatvfs.c
+--- sysdeps/unix/sysv/linux/fstatvfs.c 1998/10/23 21:15:21
+1.1.1.4
++++ sysdeps/unix/sysv/linux/fstatvfs.c 1999/04/09 22:08:15
+@@ -80,8 +76,9 @@ fstatvfs (int fd, struct statvfs *buf)
+ case UFS_MAGIC:
+ case UFS_CIGAM:
+ default:
+- /* I hope it's safe to assume no fragmentation. */
+- buf->f_frsize = buf->f_bsize;
++ /* Since Linux doesn't support f_frsize, we set it to 0. "df"
++ will be happy with it. */
++ buf->f_frsize = 0;
+ break;
+ }
+
+
+(should it really by enough that only "df" is happy about it?)
--
H.J. Lu (hjl@gnu.org)