Re: ./string/bits/string2.h in glibc 2.1.2 is bad

[hjl@lucon.org (H.J. Lu)]

> 
> hjl@lucon.org (H.J. Lu) writes:
> 
> > ./string/bits/string2.h in glibc 2.1.2 1999 0728 is bad. The one
> > in glibc 2.1.2 1999 0711 is ok. It generates the wrong code for
> > makeinfo.c in gcc 2.95 when compiled with -O2 using egcs 1.1.2.
> 
> No, the old one is not correct.  I haven't seen any problems with the
> new one.  As usual, tell me *what* is failing,, and that that it is
> failing.
> 

I have said that makeinfo in gcc 2.95 was miscompiled with -O2. Here
is the patch for the typo. Please double check your change to
string/bits/string2.h to see if there are any more obvious typos.

Thanks.


H.J.
---
Sat Jul 31 14:33:23 1999  H.J. Lu  <hjl@gnu.org>

        * string/bits/string2.h (__strcpy_small): Fix a typo.

Index: string/bits/string2.h
===================================================================
RCS file: /work/cvs/gnu/glibc-2.1/string/bits/string2.h,v
retrieving revision 1.1.1.23
diff -u -p -r1.1.1.23 string2.h
--- string/bits/string2.h	1999/07/28 16:41:11	1.1.1.23
+++ string/bits/string2.h	1999/07/31 21:32:38
@@ -442,7 +442,7 @@ __strcpy_small (char *__dest,
     case 8:
       __u->__ui = __src0_4;
       __u = (void *) __u + 4;
-      __u->__usi = __src4_4;
+      __u->__ui = __src4_4;
       break;
     }
   return __dest;