This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: A patch for csu/gmon-start.c

To: "H . J . Lu" <hjl at valinux dot com>
Subject: Re: A patch for csu/gmon-start.c
From: Roland McGrath <roland at frob dot com>
Date: Wed, 19 Apr 2000 14:55:47 -0400
Cc: GNU C Library <libc-hacker at sourceware dot cygnus dot com>, Ulrich Drepper <drepper at cygnus dot com>
Emacs: a compelling argument for pencil and paper.

I think your change is ok.  It is usual to use `extern void _end;' and the
like for this, so that &_end has type void *.  Another good choice is
`extern void _end[];' or the like; that has the benefit of `_end' rather
than `&_end' doing the right thing as it does when using a function
declaration.  (Note that `extern void _end;' has the benefit of giving you
an error if you use `_end' instead of `&_end', while your declaration using
a real type can result in confusingly bogus code that fetches from *&_end.)

Follow-Ups:
- Re: A patch for csu/gmon-start.c
  - From: H . J . Lu

References:
- A patch for csu/gmon-start.c
  - From: H . J . Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]