This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Changes for syscalls.list - questions about init/delete/create_module



Looking through sysdeps/unix/sysv/linux/syscalls.list to change the
remaining args to signatures I noticed in kernel 2.4.0-test1 (and also
in 2.2):
- create_module has 3 args, but kernel/module.c has:
  sys_create_module(const char *name_user, size_t size)
- The same problem is with delete_module:
  sys_delete_module(const char *name_user)
- and also with sys_init_module:
  sys_init_module(const char *name_user, struct module *mod_user)

Compare this with Linux 2.0:
sys_create_module(char *module_name, unsigned long size)
sys_delete_module(char *module_name)
sys_init_module(char *module_name, char *code, unsigned codesize,
                struct mod_routines *routines,
                struct symbol_table *symtab)

What shall we do with init_module?  Require Linux 2.2 or ignore it?

Here's a patch.  Is this ok to commit?

Andreas

2000-06-23  Andreas Jaeger  <aj@suse.de>

	* sysdeps/unix/sysv/linux/syscalls.list: Replace some argument
	counts with signatures.

============================================================
Index: sysdeps/unix/sysv/linux/syscalls.list
--- sysdeps/unix/sysv/linux/syscalls.list	2000/06/13 08:24:20	1.77
+++ sysdeps/unix/sysv/linux/syscalls.list	2000/06/23 06:41:23
@@ -2,13 +2,13 @@
 
 adjtimex	adjtime	adjtimex	i:p	__adjtimex	adjtimex ntp_adjtime
 bdflush		EXTRA	bdflush		i:ii	bdflush
-capget		EXTRA	capget		2	capget
-capset		EXTRA	capset		2	capset
+capget		EXTRA	capget		i:pp	capget
+capset		EXTRA	capset		i:pp	capset
 clock_getres	-	clock_getres	2	clock_getres
 clock_gettime	-	clock_gettime	2	clock_gettime
 clock_settime	-	clock_settime	2	clock_settime
-create_module	EXTRA	create_module	3	create_module
-delete_module	EXTRA	delete_module	3	delete_module
+create_module	EXTRA	create_module	i:si	create_module
+delete_module	EXTRA	delete_module	i:s	delete_module
 fdatasync	-	fdatasync	i:i	fdatasync
 flock		-	flock		i:ii	__flock		flock
 fork		-	fork		i:	__libc_fork	__fork fork
@@ -19,7 +19,7 @@
 getpgrp		-	getpgrp		i:	getpgrp
 getppid		-	getppid		i:	__getppid	getppid
 getsid		-	getsid		i:i	getsid
-init_module	EXTRA	init_module	5	init_module
+init_module	EXTRA	init_module	i:ps	init_module
 ioperm		-	ioperm		i:iii	ioperm
 iopl		-	iopl		i:i	iopl
 klogctl		EXTRA	syslog		i:isi	klogctl

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]