This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: next test release (5th)


Jakub Jelinek <jakub@redhat.com> writes:

> --- libc/nscd/nscd_gethst_r.c.jj	Wed May  3 10:19:59 2000
> +++ libc/nscd/nscd_gethst_r.c	Fri Sep 29 11:30:57 2000
> @@ -165,7 +165,7 @@ nscd_gethst_r (const char *key, size_t k
>    if (hst_resp.found == 1)
>      {
>        struct iovec vec[4];
> -      size_t *aliases_len;
> +      nscd_size_t *aliases_len;
>        char *cp = buffer;
>        uintptr_t align1;
>        uintptr_t align2;

This is perfectly fine.  There is no real need for using size_t.  I
would perhaps just using uint32_t and int32_t instead of introducing
another type.  I'll probably make this change in your patch.
Otherwise people will ask why such a named type is necessry.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]