This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] Fix for localalias.c bug

To: Jakub Jelinek <jakub at redhat dot com>
Subject: Re: [PATCH] Fix for localalias.c bug
From: Ulrich Drepper <drepper at redhat dot com>
Date: 14 Oct 2000 18:57:35 -0700
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
References: <20001010231941.I807@sunsite.ms.mff.cuni.cz>
Reply-To: drepper at cygnus dot com (Ulrich Drepper)

Jakub Jelinek <jakub@redhat.com> writes:

> Below are two possible solutions for a pretty old bug in
> localealias.c which is visible under ElectricFence: If the
> string_space pool is too small, it is realloced, but realloc does
> not guarantee it will return the same pointer as was passed to it,
> but we already stored many string pointers to the old pool into the
> map array.

Good catch.  I've applied your patch P2.  It's I think easier but the
main argument is that the code to free the buffers does not have to be
changed.  The only thing I changed is adding a __builtin_expect().

Thanks,

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

References:
- [PATCH] Fix for localalias.c bug
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]