This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: A forgotten patch for SH


kaz Kojima <kkojima@rr.iij4u.or.jp> wrote:
> Ulrich Drepper <drepper@redhat.com> wrote:
>>> 	* sysdeps/sh/bits/setjmp.h: Move
>>> 	* sysdeps/sh/sh4/bits/setjmp.h: to here.
>>> 	* sysdeps/sh/sh3/bits/setjmp.h: New file.
>> 
>> I've applied the patch now.  But please remember: we've changed this
>> some time back (2000-6-7) to have the same definition on both SH3 and
>> SH4.  This increases binary compatibility.  You have now reverted this
>> change and went back to the original definition.
>
> This patch is requested by SH3 people, but I may be confused as you
> pointed out. I could fix sh3/setjmp.S and sh3/__longjmp.S so to use
> one common setjmp.h. I'll ask SH3 people whether this is ok or not.

They say that you are right. I'd like to withdraw my previous patch
and want to fix sh/sh3/setjmp.S only. Is it ok?
Sorry for my confusion.

	kaz
--

	* sysdeps/sh/sh3/setjmp.S (__sigsetjmp): Skip FPU fields.

Index: setjmp.S
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/sh/sh3/setjmp.S,v
retrieving revision 1.1
diff -u -r1.1 setjmp.S
--- setjmp.S	2000/06/12 20:09:26	1.1
+++ setjmp.S	2000/11/08 02:22:41
@@ -1,4 +1,4 @@
-/* setjmp for SH4.
+/* setjmp for SH3.
    Copyright (C) 1999, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
@@ -27,7 +27,7 @@
 	mov	#0, r5
 ENTRY (__sigsetjmp)
 	/* Save registers */
-	add	#JB_SIZE, r4
+	add	#(JB_SIZE - 4 * 5), r4
 	stc.l	gbr, @-r4
 	sts.l	pr, @-r4
 	mov.l	r15, @-r4

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]