This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] Avoid some warnings in make check

To: Jakub Jelinek <jakub at redhat dot com>
Subject: Re: [PATCH] Avoid some warnings in make check
From: Ulrich Drepper <drepper at redhat dot com>
Date: 20 Nov 2000 09:41:56 -0800
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
References: <20001120154138.X635@sunsite.ms.mff.cuni.cz>
Reply-To: drepper at cygnus dot com (Ulrich Drepper)

Jakub Jelinek <jakub@redhat.com> writes:

> This patch kills quite a few warnings during make check (seen on sparc64).

Thanks, I've applied it.

> - What format string modifier should be used for wint_t type arguments?
>   Some archs define it as unsigned long int, some as unsigned int...
>   This causes most of the warnings not fixed by this patch.

Since this will always be inconsistent we should use %ld and
explicitly cast the parameter to (long int).

> - We should avoid direct casts between void * and int, because at least
>   sparc64 gcc warns about those casts. Casting to long in between makes it
>   go away.

Same is true for all 64 bit targets.  It was always intended to do
this.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

References:
- [PATCH] Avoid some warnings in make check
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]