This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

More warnings patches



These patches remove some more warnings.  Uli, I noticed that
locale/codeset_name.c is not used anywhere in glibc.  The patch
removes it.

Btw. the  _dl_sysdep_start prototype in rtld.c was wrong.

Uli, what do you think of declaring _dl_load_cache_lookup,
_dl_sysdep_read_whole_file and _dl_sysdep_start_cleanup as internal
functions?

Ok to commit?

Andreas

2000-12-05  Andreas Jaeger  <aj@suse.de>

	* sysdeps/generic/ldsodefs.h: Add declarations of
	_dl_load_cache_lookup, _dl_unload_cache,
	_dl_sysdep_read_whole_file, _dl_sysdep_start and
	_dl_sysdep_start_cleanup.

	* elf/rtld.c: Remove prototypes that are defined in ldsodefs.h
	now.

	* elf/dl-misc.c: Include <ldsodefs.h> to get prototypes.
	* sysdeps/generic/dl-environ.c: Likewise.

	* stdio-common/printf_fp.c: Include <gmp.h> instead of
	<stdlib/gmp.h>.
	* math/atest-exp.c: Likewise.
	* math/atest-exp2.c: Likewise.
	* math/atest-sincos.c: Likewise.
	* stdio-common/_itoa.c: Likewise.
	* stdio-common/_itowa.c: Likewise.

	* include/gmp.h: New file with internal prototypes.

	* sysdeps/generic/longjmp.c: Move _longjmp_unwind declaration from
	here to...
	* include/setjmp.h: ...here.

	* locale/Makefile (routines): Remove codeset_name since it's not
	needed anywhere.

	* locale/codeset_name.c: Removed.

============================================================
Index: stdio-common/printf_fp.c
--- stdio-common/printf_fp.c	2000/10/26 23:39:35	1.41
+++ stdio-common/printf_fp.c	2000/12/05 09:28:08
@@ -30,7 +30,7 @@
 #include <ctype.h>
 #include <float.h>
 #include <gmp-mparam.h>
-#include <stdlib/gmp.h>
+#include <gmp.h>
 #include <stdlib/gmp-impl.h>
 #include <stdlib/longlong.h>
 #include <stdlib/fpioconst.h>
============================================================
Index: stdio-common/_itoa.c
--- stdio-common/_itoa.c	1999/06/16 22:32:42	1.14
+++ stdio-common/_itoa.c	2000/12/05 09:28:09
@@ -1,5 +1,5 @@
 /* Internal function for converting integers to ASCII.
-   Copyright (C) 1994, 1995, 1996, 1999 Free Software Foundation, Inc.
+   Copyright (C) 1994, 1995, 1996, 1999, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Torbjorn Granlund <tege@matematik.su.se>
    and Ulrich Drepper <drepper@gnu.org>.
@@ -20,7 +20,7 @@
    Boston, MA 02111-1307, USA.  */
 
 #include <gmp-mparam.h>
-#include <stdlib/gmp.h>
+#include <gmp.h>
 #include <stdlib/gmp-impl.h>
 #include <stdlib/longlong.h>
 
============================================================
Index: stdio-common/_itowa.c
--- stdio-common/_itowa.c	1999/06/16 22:33:55	1.1
+++ stdio-common/_itowa.c	2000/12/05 09:28:09
@@ -1,5 +1,5 @@
 /* Internal function for converting integers to ASCII.
-   Copyright (C) 1994, 1995, 1996, 1999 Free Software Foundation, Inc.
+   Copyright (C) 1994, 1995, 1996, 1999, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Torbjorn Granlund <tege@matematik.su.se>
    and Ulrich Drepper <drepper@gnu.org>.
@@ -20,7 +20,7 @@
    Boston, MA 02111-1307, USA.  */
 
 #include <gmp-mparam.h>
-#include <stdlib/gmp.h>
+#include <gmp.h>
 #include <stdlib/gmp-impl.h>
 #include <stdlib/longlong.h>
 
============================================================
Index: math/atest-exp.c
--- math/atest-exp.c	2000/12/04 07:25:46	1.5
+++ math/atest-exp.c	2000/12/05 09:28:09
@@ -19,7 +19,7 @@
 
 #include <stdio.h>
 #include <math.h>
-#include <stdlib/gmp.h>
+#include <gmp.h>
 #include <string.h>
 #include <limits.h>
 #include <assert.h>
============================================================
Index: math/atest-exp2.c
--- math/atest-exp2.c	2000/12/04 07:27:26	1.6
+++ math/atest-exp2.c	2000/12/05 09:28:09
@@ -19,7 +19,7 @@
 
 #include <stdio.h>
 #include <math.h>
-#include <stdlib/gmp.h>
+#include <gmp.h>
 #include <string.h>
 #include <limits.h>
 #include <assert.h>
============================================================
Index: math/atest-sincos.c
--- math/atest-sincos.c	2000/12/04 07:25:17	1.5
+++ math/atest-sincos.c	2000/12/05 09:28:10
@@ -19,7 +19,7 @@
 
 #include <stdio.h>
 #include <math.h>
-#include <stdlib/gmp.h>
+#include <gmp.h>
 #include <string.h>
 #include <limits.h>
 #include <assert.h>
============================================================
Index: sysdeps/generic/longjmp.c
--- sysdeps/generic/longjmp.c	1998/04/20 18:25:52	1.3
+++ sysdeps/generic/longjmp.c	2000/12/05 09:28:10
@@ -1,4 +1,4 @@
-/* Copyright (C) 1991, 92, 94, 95, 97, 98 Free Software Foundation, Inc.
+/* Copyright (C) 1991, 92, 94, 95, 97, 98, 2000 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -20,8 +20,6 @@
 #include <setjmp.h>
 #include <signal.h>
 
-
-extern void _longjmp_unwind (jmp_buf env, int val);
 
 /* Set the signal mask to the one specified in ENV, and jump
    to the position specified in ENV, causing the setjmp
============================================================
Index: sysdeps/generic/ldsodefs.h
--- sysdeps/generic/ldsodefs.h	2000/11/16 18:15:15	1.19
+++ sysdeps/generic/ldsodefs.h	2000/12/05 09:28:10
@@ -456,6 +456,33 @@
 							size_t *max_capstrlen)
      internal_function;
 
+/* Look up NAME in ld.so.cache and return the file name stored there,
+   or null if none is found.  */
+extern const char *_dl_load_cache_lookup (const char *name);
+
+/* If the system does not support MAP_COPY we cannot leave the file open
+   all the time since this would create problems when the file is replaced.
+   Therefore we provide this function to close the file and open it again
+   once needed.  */
+extern void _dl_unload_cache (void);
+
+/* System-dependent function to read a file's whole contents
+   in the most convenient manner available.  */
+extern void *_dl_sysdep_read_whole_file (const char *file, size_t *sizep,
+					 int prot);
+
+/* System-specific function to do initial startup for the dynamic linker.
+   After this, file access calls and getenv must work.  This is responsible
+   for setting __libc_enable_secure if we need to be secure (e.g. setuid),
+   and for setting _dl_argc and _dl_argv, and then calling _dl_main.  */
+extern ElfW(Addr) _dl_sysdep_start (void **start_argptr,
+				    void (*dl_main) (const ElfW(Phdr) *phdr,
+						     ElfW(Word) phnum,
+						     ElfW(Addr) *user_entry));
+
+extern void _dl_sysdep_start_cleanup (void);
+
+
 __END_DECLS
 
 #endif /* ldsodefs.h */
============================================================
Index: sysdeps/generic/dl-environ.c
--- sysdeps/generic/dl-environ.c	2000/05/04 02:35:09	1.2
+++ sysdeps/generic/dl-environ.c	2000/12/05 09:28:10
@@ -18,7 +18,7 @@
    Boston, MA 02111-1307, USA.  */
 
 #include <string.h>
-
+#include <ldsodefs.h>
 
 extern char **_environ;
 
============================================================
Index: include/setjmp.h
--- include/setjmp.h	1999/11/23 17:28:08	1.4
+++ include/setjmp.h	2000/12/05 09:28:10
@@ -12,4 +12,7 @@
    This is used by the machine-dependent definition of `__sigsetjmp'.
    Always returns zero, for convenience.  */
 extern int __sigjmp_save (jmp_buf __env, int __savemask);
+
+extern void _longjmp_unwind (jmp_buf env, int val);
+
 #endif
============================================================
Index: locale/Makefile
--- locale/Makefile	2000/10/26 23:35:03	1.54
+++ locale/Makefile	2000/12/05 09:28:11
@@ -35,7 +35,7 @@
 			      locfile.h charmap.h repertoire.h localedef.h \
 			      3level.h charmap-dir.h)
 routines	= setlocale findlocale loadlocale localeconv nl_langinfo \
-		  nl_langinfo_l mb_cur_max codeset_name \
+		  nl_langinfo_l mb_cur_max \
 		  newlocale duplocale freelocale
 tests		= tst-C-locale
 categories	= ctype messages monetary numeric time paper name \
============================================================
Index: elf/dl-misc.c
--- elf/dl-misc.c	2000/08/16 01:22:34	1.12
+++ elf/dl-misc.c	2000/12/05 09:28:11
@@ -19,6 +19,7 @@
 
 #include <assert.h>
 #include <fcntl.h>
+#include <ldsodefs.h>
 #include <link.h>
 #include <stdarg.h>
 #include <string.h>
============================================================
Index: elf/rtld.c
--- elf/rtld.c	2000/10/24 07:35:08	1.185
+++ elf/rtld.c	2000/12/05 09:28:12
@@ -34,25 +34,6 @@
 
 #include <assert.h>
 
-/* System-specific function to do initial startup for the dynamic linker.
-   After this, file access calls and getenv must work.  This is responsible
-   for setting __libc_enable_secure if we need to be secure (e.g. setuid),
-   and for setting _dl_argc and _dl_argv, and then calling _dl_main.  */
-extern ElfW(Addr) _dl_sysdep_start (void **start_argptr,
-				    void (*dl_main) (const ElfW(Phdr) *phdr,
-						     ElfW(Half) phent,
-						     ElfW(Addr) *user_entry));
-extern void _dl_sysdep_start_cleanup (void);
-
-/* This function is used to unload the cache file if necessary.  */
-extern void _dl_unload_cache (void);
-
-/* System-dependent function to read a file's whole contents
-   in the most convenient manner available.  */
-extern void *_dl_sysdep_read_whole_file (const char *filename,
-					 size_t *filesize_ptr,
-					 int mmap_prot);
-
 /* Helper function to handle errors while resolving symbols.  */
 static void print_unresolved (int errcode, const char *objname,
 			      const char *errsting);
============================================================
Index: include/gmp.h
--- include/gmp.h	created
+++ include/gmp.h	Tue Dec  5 09:43:23 2000	1.1
@@ -0,0 +1,23 @@
+#ifndef __GMP_H__
+
+#include <stdlib/gmp.h>
+
+/* Now define the internal interfaces.  */
+extern mp_size_t __mpn_extract_double (mp_ptr res_ptr, mp_size_t size,
+				       int *expt, int *is_neg,
+				       double value);
+
+extern mp_size_t __mpn_extract_long_double (mp_ptr res_ptr, mp_size_t size,
+					    int *expt, int *is_neg,
+					    long double value);
+
+extern float __mpn_construct_float (mp_srcptr frac_ptr, int expt, int sign);
+
+extern double __mpn_construct_double (mp_srcptr frac_ptr, int expt,
+				      int negative);
+
+extern long double __mpn_construct_long_double (mp_srcptr frac_ptr, int expt,
+						int sign);
+
+
+#endif
============================================================
Index: locale/codeset_name.c
--- locale/codeset_name.c	Sat Jan 17 10:57:34 1998	1.2
+++ locale/codeset_name.c	removed
@@ -1,31 +0,0 @@
-/* Internal function to return the name of the current codeset.
-   Copyright (C) 1996, 1997 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Ulrich Drepper <drepper@cygnus.com>, 1996.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Library General Public License as
-   published by the Free Software Foundation; either version 2 of the
-   License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Library General Public License for more details.
-
-   You should have received a copy of the GNU Library General Public
-   License along with the GNU C Library; see the file COPYING.LIB.  If not,
-   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
-   Boston, MA 02111-1307, USA.  */
-
-#include <langinfo.h>
-#include <locale.h>
-#include <stdlib.h>
-#include "localeinfo.h"
-
-
-const char *
-__ctype_get_codeset_name (void)
-{
-  return _NL_CURRENT (LC_CTYPE, _NL_CTYPE_CODESET_NAME);
-}

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]