This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] Fix alphaev6 stpcpy

To: Ulrich Drepper <drepper at cygnus dot com>
Subject: Re: [PATCH] Fix alphaev6 stpcpy
From: Jakub Jelinek <jakub at redhat dot com>
Date: Sun, 10 Dec 2000 23:43:27 +0100
Cc: rth at redhat dot com, rick dot gorton at alpha-processor dot com, Glibc hackers <libc-hacker at sources dot redhat dot com>
References: <20001210231144.P552@sunsite.ms.mff.cuni.cz> <m3k8979ai9.fsf@otr.mynet.cygnus.com>
Reply-To: Jakub Jelinek <jakub at redhat dot com>

On Sun, Dec 10, 2000 at 02:28:30PM -0800, Ulrich Drepper wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
> 
> > New alphaev6 stxcpy broke stpcpy: stpcpy.S expects certain value in t8,
> > while the new ev6 stxcpy had that value in t10.
> 
> Since rth also complained about rpcgen I assume this is correct.  I've
> applied the patch.
> 
> Jakub: please provide a test case for the string function tests.  Any
> error should be caught there.

I believe string/tester.c would have caught this, it is testing the return
value from stpcpy in a lot of tests.
The failure in rpcgen was:
stpcpy (stpcpy (pathbuf, "/lib"), "/cpp");
resulted in "/lib" in pathbuf, then '\0', then something.
I'm not sure what exact offset % 8 "/lib" had, but I think it did not matter
much.

	Jakub

Follow-Ups:
- Re: [PATCH] Fix alphaev6 stpcpy
  - From: Ulrich Drepper

References:
- [PATCH] Fix alphaev6 stpcpy
  - From: Jakub Jelinek
- Re: [PATCH] Fix alphaev6 stpcpy
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]