This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

[PATCH] Robustify globtest.sh


Hi!

It was not the first time globtest failed for me (in some buildroots homes
are not mounted sometimes and if I sudo -H bash, then chroot, $HOME points
to something which isn't there), so I guess it would be better if those
tests just weren't run in that case.

2001-08-09  Jakub Jelinek  <jakub@redhat.com>

	* posix/globtest.sh: Robustify tilde tests.

--- posix/globtest.sh.jj	Mon Jul 24 09:24:13 2000
+++ posix/globtest.sh	Thu Aug  9 12:58:43 2001
@@ -324,8 +324,12 @@ ${common_objpfx}posix/globtest -q -t "$t
 sort >$testout
 echo ~ | cmp - $testout >> $logfile || failed=1
 if test $failed -ne 0; then
-  echo "Tilde test failed" >> $logfile
-  result=1
+  if test -d ~; then
+    echo "Tilde test failed" >> $logfile
+    result=1
+  else
+    echo "Tilde test could not be run" >> $logfile
+  fi
 fi
 
 # Test tilde expansion with trailing slash
@@ -340,8 +344,12 @@ else
     echo ~/ | cmp - $testout >> $logfile || failed=1
 fi
 if test $failed -ne 0; then
-  echo "Tilde2 test failed" >> $logfile
-  result=1
+  if test -d ~/; then
+    echo "Tilde2 test failed" >> $logfile
+    result=1
+  else
+    echo "Tilde2 test could not be run" >> $logfile
+  fi
 fi
 
 # Test tilde expansion with username
@@ -351,8 +359,12 @@ ${common_objpfx}posix/globtest -q -t "$t
 sort > $testout
 eval echo ~$USER | cmp - $testout >> $logfile || failed=1
 if test $failed -ne 0; then
-  echo "Tilde3 test failed" >> $logfile
-  result=1
+  if eval test -d ~$USER; then
+    echo "Tilde3 test failed" >> $logfile
+    result=1
+  else
+    echo "Tilde3 test could not be run" >> $logfile
+  fi
 fi
 
 # Tilde expansion shouldn't match a file

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]