This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix mmap stdio bug

From: Ulrich Drepper <drepper at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: 18 Feb 2002 23:18:18 -0800
Subject: Re: [PATCH] Fix mmap stdio bug
References: <20020219013402.L533@sunsite.ms.mff.cuni.cz>
Reply-to: drepper at redhat dot com (Ulrich Drepper)

Jakub Jelinek <jakub@redhat.com> writes:

> I think the patch is self-explaining and I'm not sure how useful is to
> include a testcase for this into the testsuite (on ia64 ld could not link
> crti.o because it was trying to fseek to a location in the file which
> contained '\xff').

I think test cases are always useful.

> 2002-02-19  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* libio/fileops.c (_IO_file_underflow_mmap): Cast to unsigned char
> 	pointer before dereferencing.

The patch is in now.  Thanks,

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

References:
- [PATCH] Fix mmap stdio bug
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]