This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix newlocale, uselocale, duplocale, is*_l and to*_l


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jakub Jelinek wrote:

strdup of strdup?
And while we are at it: the various strdups should be collapsed. The individual memory allocations are rather expensive. Just collect the sizes of the names while iterating over the locales and allocate one chunk of memory. The size doesn't have to be exact. When newlocale is called with base != NULL the memory block can be resized (if necessary).

- -- - ---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQE9cRV92ijCOnn/RHQRAhjUAKDGub9gLgGtYgdK4vTU7HrjLHZgPACfdQ9J
ZpTfX4ALAh50Zy61uhT3v2E=
=/6Qw
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]