This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] libc x86-64 __thread fix

From: Jakub Jelinek <jakub at redhat dot com>
To: Roland McGrath <roland at redhat dot com>
Cc: Ulrich Drepper <drepper at redhat dot com>, Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Mon, 14 Oct 2002 23:00:27 +0200
Subject: Re: [PATCH] libc x86-64 __thread fix
References: <20021014162717.G3451@sunsite.ms.mff.cuni.cz> <200210141937.g9EJbxx13170@magilla.sf.frob.com>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Mon, Oct 14, 2002 at 12:37:59PM -0700, Roland McGrath wrote:
> Something is wrong if you need that.  USE___THREAD != HAVE___THREAD.
> Why is USE___THREAD defined in your rtld build?

Actually, maybe just the #include <tls.h> is needed.
The problem was that without including tls.h uname.os etc. in libc-pic.a
was calling __errno_location(), which caused rtld-errno-loc.os to be
added into librtld.a. But rtld-errno-loc.os would not compile, because
errno was first defined as normal variable in include/errno.h and then
redefined as __thread variable in sysdeps/generic/errno-loc.c.
Though IMHO putting RTLD_PRIVATE_ERRNO case before USE__THREAD
shouldn't hurt.

	Jakub

Follow-Ups:
- Re: [PATCH] libc x86-64 __thread fix
  - From: Roland McGrath

References:
- [PATCH] libc x86-64 __thread fix
  - From: Jakub Jelinek
- Re: [PATCH] libc x86-64 __thread fix
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]