This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Re: Glibc broken for ia64


> Ok, testing revealed a problem.
> With
> #ifdef USE_TLS
> MULTIPLE_THREADS_OFFSET offsetof (struct _pthread_descr_struct, p_header.data.multiple_threads) - sizeof (struct _pthread_descr_struct)
> #else
> MULTIPLE_THREADS_OFFSET offsetof (tcbhead_t, multiple_threads)
> #endif
> in the .sym file we try to compile
> #ifdef USE_TLS
> void dummy(void) {
> asm ("@@@name@@@MULTIPLE_THREADS_OFFSET@@@value@@@%0@@@end@@@" : : "i" (something));
> #else
> asm ("@@@name@@@MULTIPLE_THREADS_OFFSET@@@value@@@%0@@@end@@@" : : "i" (somethingelse));
> #endif
> }

Yeah, I noticed that at the start and never did anything about it.  I think
having an explicit non-kludge separator between the includes and the
expressions is fine, either your patch or just something like:
	$1 == "--" { next }
There is no reason to pass anything like comments through, it's just an
intermediate file.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]