This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

More sigevent ...


Looking into the problem a bit deeper here's my analysis of the whole
missmatch of struct sigevent and the associated constants, including the
entire history.

 - Linux 2.1.72 introduces sigevent.  The definition used is the one taken
   from IRIX and different from what is used in other Linux ports.  But
   that doesn't matter because there are no in-kernel users.

   I don't know why the structure was defined at all in kernel headers at
   all by that time.  Maybe for the sake of libc 5?

 - Some of the >= libc 2.1 version circulating use the kernel definitions

 - Andreas Jaeger contributes sysdeps/unix/sysv/linux/mips/bits/siginfo.h
   for the FSF version of glibc 2.1.  Markedrd as "XXX This one might need
   to change!!!" this header file uses the same structure as other Linux
   architectures but uses the same SIGEV_* constants as the kernel.

 - Linux 2.5.63 introduces the POSIX.1b timer API which uses the kernel's
   definition of sigevent.  The userspace part of the POSIX.1b timer patch
   uses glibc's definition.  But the code assumes both definitions are
   identical ...

Time to resolve the mess.  I see the following options:

 - Yet another syscall wrapper that does argument conversion.  Imho the
   most icky solution.

 - Change the kernel to use the same definition as glibc.  Not really an
   option, SIGEV_CALLBACK has to go.

 - Two part solution:
   - Change the kernel definition to what other architectures use (Done,
     may have to be undone depending on the outcome of this discussion).

   - Remove SIGEV_CALLBACK from glibc which would result in SIGEV_THREAD
     getting renumbered to the same value as in the kernel.
     (This is in my withdrawn libc patch from the weekend.)

   Grepping around in plenty of Linux code I've not found any users of
   SIGEV_THREAD so this would be my prefered solution.

   SIGEV_CALLBACK would have to be removed in any case; it's a dead
   definition with no functionality.  Is it supposed to do what
   SIGEV_THREAD_ID does?  I've been digging around in parts of the Redhat 9
   source code and haven't found any users of SIGEV_THREAD, so it seems
   this is a very rarely used feature and we can change without any major
   compatibility issues.

Comments?

  Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]