This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: One more gconv_simple lcast patch

From: Andreas Jaeger <aj at suse dot de>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Sat, 21 Feb 2004 19:23:45 +0100
Subject: Re: One more gconv_simple lcast patch
References: <m3hdxkcygj.fsf@gromit.moeb> <4037A02D.7060804@redhat.com>

Ulrich Drepper <drepper@redhat.com> writes:

> Andreas Jaeger wrote:
>
>>    for (cnt = 0; cnt < n_convert; ++cnt, inptr += 4)
>> -    *((uint32_t *) outptr)++ = bswap_32 (*(const uint32_t *) inptr);
>> +    *outptr32++ = bswap_32 (*(const uint32_t *) inptr);
>> +  outptr = (unsigned char *) outptr32;
>>  
>>    *inptrp = inptr;
>>    *outptrp = outptr;
>
> Why the second added line?  Just do it in the assignment to *outptrp.

Ok, will do...
Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

References:
- One more gconv_simple lcast patch
  - From: Andreas Jaeger
- Re: One more gconv_simple lcast patch
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]