This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.
Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi, The end address of a critical section in a software atomic sequence of SH must have 4-byte alignment, because MOVA instruction needs it. The attached patch fixes a few mistakes about that. Regards, kaz -- 2004-06-03 Kaz Kojima <kkojima@rr.iij4u.or.jp> * sysdeps/unix/sysv/linux/sh/lowlevellock.h (lll_mutex_lock): Add nop to align the end of critical section. (lll_mutex_cond_lock, lll_mutex_timedlock): Likewise. diff -u3prN ORIG/libc/nptl/sysdeps/unix/sysv/linux/sh/lowlevellock.h LOCAL/libc/nptl/sysdeps/unix/sysv/linux/sh/lowlevellock.h --- ORIG/libc/nptl/sysdeps/unix/sysv/linux/sh/lowlevellock.h Tue Mar 30 10:41:09 2004 +++ LOCAL/libc/nptl/sysdeps/unix/sysv/linux/sh/lowlevellock.h Thu Jun 3 22:57:03 2004 @@ -89,6 +89,7 @@ extern int __lll_mutex_unlock_wake (int __asm __volatile ("\ .align 2\n\ mova 1f,r0\n\ + nop\n\ mov r15,r1\n\ mov #-8,r15\n\ 0: mov.l @%2,%0\n\ @@ -108,6 +109,7 @@ extern int __lll_mutex_unlock_wake (int __asm __volatile ("\ .align 2\n\ mova 1f,r0\n\ + nop\n\ mov r15,r1\n\ mov #-8,r15\n\ 0: mov.l @%2,%0\n\ @@ -125,6 +127,7 @@ extern int __lll_mutex_unlock_wake (int __asm __volatile ("\ .align 2\n\ mova 1f,r0\n\ + nop\n\ mov r15,r1\n\ mov #-8,r15\n\ 0: mov.l @%2,%0\n\
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |