This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix i386 <bits/string.h>


Jakub Jelinek <jakub@redhat.com> writes:

> --- libc/sysdeps/i386/bits/string.h.jj	2003-09-05 06:03:03.000000000 -0400
> +++ libc/sysdeps/i386/bits/string.h	2004-06-13 15:35:35.000000000 -0400
> @@ -43,8 +43,8 @@
>  #define _HAVE_STRING_ARCH_memcpy 1
>  #define memcpy(dest, src, n) \
>    (__extension__ (__builtin_constant_p (n)				      \
> -		  ? __memcpy_c (dest, src, n)				      \
> -		  : memcpy (dest, src, n)))
> +		  ? __memcpy_c ((dest), (src), (n))			      \
> +		  : memcpy ((dest), (src), (n))))

These parens are useless.  It is impossible to pass a comma inside a macro
argument without putting it in parens itself.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]