This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Allow main to come from a shared library for PIE [BZ #262]


On Thu, Jul 15, 2004 at 03:02:45PM -0700, Roland McGrath wrote:
> > +ifeq (yesyes,$(have-fpie)$(build-shared))
> > +tests: $(objpfx)tst-pie1.out
> > +endif
> 
> This should be tests += tst-pie1.

No, when it is tests += tst-pie1, the elf/Makefile
$(objpfx)/tst-pie1 rule is overriding the default one.
I used tests += tst-pie1 initially but changed it afterwards.
Maybe if we have more PIE tests in the future the Makefiles could have some
common rule how to build them, but for one test I think what the patch does
is enough.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]