This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.
Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi! wget -O ia64-libm.patch.bz2 'http://sources.redhat.com/bugzilla/attachment.cgi?id=327&action=view' bzcat ia64-libm.patch.bz2 | patch -p0 -E rm -f sysdeps/ia64/fpu/e_atan2l.S sysdeps/ia64/fpu/e_expl.S with the following fix on top of it looks good for me (no make check regressions, no ABI changes, the licensing comments look ok as well and it doesn't introduce new libc.so PLT slots (and even removes some libm.so PLT slots). Can you please apply? Thanks. 2004-12-29 Jakub Jelinek <jakub@redhat.com> * sysdeps/ia64/fpu/libm_support.h (__libm_error_support): Use libc_hidden_proto instead of HIDDEN_PROTO. * sysdeps/ia64/fpu/libm-symbols.h (HIDDEN_PROTO): Remove. (__libm_error_support): If ASSEMBLER and in libc, define to HIDDEN_JUMPTARGET(__libm_error_support). --- sysdeps/ia64/fpu/libm_support.h.jj 2004-12-29 05:02:00.678755000 -0500 +++ sysdeps/ia64/fpu/libm_support.h 2004-12-29 05:27:08.673668532 -0500 @@ -286,7 +286,7 @@ typedef enum void __libm_error_support(void*,void*,void*,error_types); #ifdef _LIBC -HIDDEN_PROTO(__libm_error_support) +libc_hidden_proto(__libm_error_support) #endif #define HI_SIGNIFICAND_LESS(X, HI) ((X)->hi_significand < 0x ## HI) --- sysdeps/ia64/fpu/libm-symbols.h.jj 2004-12-29 05:02:00.576216000 -0500 +++ sysdeps/ia64/fpu/libm-symbols.h 2004-12-29 05:30:41.246042994 -0500 @@ -59,8 +59,6 @@ ASM_SIZE_DIRECTIVE(__ieee754_##name); \ ASM_TYPE_DIRECTIVE(__ieee754_##name, @function) -#ifdef ASSEMBLER -# define HIDDEN_PROTO(name) HIDDEN_JUMPTARGET(name) -#else -# define HIDDEN_PROTO(name) libc_hidden_proto(name) +#if defined ASSEMBLER && !defined NOT_IN_libc +# define __libm_error_support HIDDEN_JUMPTARGET(__libm_error_support) #endif Jakub
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |