This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix futimesat with NULL second argument


Jakub Jelinek <jakub@redhat.com> writes:

> According to http://docs.sun.com/app/docs/doc/816-5167/6mbb2jam2?a=view
> futimesat (fd, NULL, tvp)
> is supposed to set times on the file referenced by fd.
>
> touch from coreutils uses this, so with current CVS glibc crashes
> (see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173581).

It still crashes.

Andreas.

2005-11-24  Andreas Schwab  <schwab@suse.de>

	* time/sys/time.h: Remove nonnull attribute from futimesat.

--- time/sys/time.h.~1.36.~	2005-11-13 22:35:20.000000000 +0100
+++ time/sys/time.h	2005-11-24 15:29:18.000000000 +0100
@@ -153,7 +153,7 @@ extern int futimes (int __fd, __const st
    modification time of FILE to TVP[1].  If TVP is a null pointer, use
    the current time instead.  Returns 0 on success, -1 on errors.  */
 extern int futimesat (int __fd, __const char *__file,
-		      __const struct timeval __tvp[2]) __THROW __nonnull ((2));
+		      __const struct timeval __tvp[2]) __THROW;
 #endif
 
 

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]