This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.
Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.
| Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
|---|---|---|
| Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
| Other format: | [Raw text] | |
On Thu, Mar 02, 2006 at 08:00:47AM -0800, Ulrich Drepper wrote:
> I've applied the patch but this really cannot be a long-term solution.
> Either the arch goes away or it gets an ABI which isn't an open
> invitation for attackers.
>
It is broken since elf/check-textrel.c is compiled with
cd /export/build/gnu/glibc-nptl-4.1-redhat/build-x86_64-linux/elf && gcc -pipe -O -Wall -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -include ../config.h /export/gnu/src/glibc/libc/elf/check-textrel.c -o check-textrel
/export/gnu/src/glibc/libc/elf/check-textrel.c:21:20: error: config.h:
No such file or directory
There is no need to include "config.h" since there is "-include
../config.h" already. This patch fixes it.
H.J.
----
2006-03-02 H.J. Lu <hongjiu.lu@intel.com>
* elf/check-textrel.c: Don't include "config.h".
--- elf/check-textrel.c.foo 2006-03-02 09:17:08.000000000 -0800
+++ elf/check-textrel.c 2006-03-02 10:14:10.000000000 -0800
@@ -18,7 +18,6 @@
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA. */
-#include "config.h"
#include <byteswap.h>
#include <elf.h>
#include <endian.h>
| Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
|---|---|---|
| Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |