This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix LC_TIME in ar_SA and dz_BT locales

On Mon, Jul 16, 2007 at 01:25:51PM +0200, Jakub Jelinek wrote:
> These 2 locales contain invalid strftime conversion modifiers.  E.g.
> LC_ALL=ar_SA.UTF-8 date +%c
> shows %.1d and %.1H in the string where one would expect day and hour,
> LC_ALL=dz_BT.UTF-8 date +%X
> shows %   H and doesn't display hour anywhere.

Actually, %.1d -> %e and %.1H -> %k might be a better idea, guess that's
almost what that meant (not sure if the padding is acceptable or not, but
we don't support %.1{d,H}, so this is certainly an improvement over what we
had).

2007-07-16  Jakub Jelinek  <jakub@redhat.com>

	* locales/ar_SA (d_t_fmt, d_fmt, t_fmt, t_fmt_ampm): Replace %.1d
	with supported %e and %.1H with %k.
	* locales/dz_BT (t_fmt): Remove whitespace between % and H.

--- libc/localedata/locales/ar_SA.jj	2006-07-31 00:19:44.000000000 +0200
+++ libc/localedata/locales/ar_SA	2007-07-16 12:19:29.000000000 +0200
@@ -294,16 +294,16 @@ END LC_NUMERIC
 
 
 % Set up the LC_TIME category
-% d_t_fmt	"%A %.1d %B %Y  %.1H:%M:%S"
-% d_fmt	"%A %.1d %B %Y"
-% t_fmt	"%.1H:%M:%S"
-% t_fmt_ampm	"%.1H:%M:%S"
+% d_t_fmt	"%A %e %B %Y  %k:%M:%S"
+% d_fmt	"%A %e %B %Y"
+% t_fmt	"%k:%M:%S"
+% t_fmt_ampm	"%k:%M:%S"
 
 LC_TIME
-d_t_fmt	"<U0025><U0041><U0020><U0025><U002E><U0031><U0064><U0020><U0025><U0042><U0020><U0025><U0059><U0020><U0020><U0025><U002E><U0031><U0048><U003A><U0025><U004D><U003A><U0025><U0053>"
-d_fmt	"<U0025><U0041><U0020><U0025><U002E><U0031><U0064><U0020><U0025><U0042><U0020><U0025><U0059>"
-t_fmt	"<U0025><U002E><U0031><U0048><U003A><U0025><U004D><U003A><U0025><U0053>"
-t_fmt_ampm	"<U0025><U002E><U0031><U0048><U003A><U0025><U004D><U003A><U0025><U0053>"
+d_t_fmt	"<U0025><U0041><U0020><U0025><U0065><U0020><U0025><U0042><U0020><U0025><U0059><U0020><U0020><U0025><U006B><U003A><U0025><U004D><U003A><U0025><U0053>"
+d_fmt	"<U0025><U0041><U0020><U0025><U0065><U0020><U0025><U0042><U0020><U0025><U0059>"
+t_fmt	"<U0025><U006B><U003A><U0025><U004D><U003A><U0025><U0053>"
+t_fmt_ampm	"<U0025><U006B><U003A><U0025><U004D><U003A><U0025><U0053>"
 day	"<U0627><U0644><U0623><U062D><U062F>"; /
 	"<U0627><U0644><U0625><U062B><U0646><U064A><U0646>"; /
 	"<U0627><U0644><U062B><U0644><U0627><U062B><U0627><U0621>"; /
--- libc/localedata/locales/dz_BT.jj	2006-07-31 00:19:44.000000000 +0200
+++ libc/localedata/locales/dz_BT	2007-07-16 12:14:16.000000000 +0200
@@ -1293,7 +1293,7 @@ d_fmt        "<U0F54><U0F66><U0FB1><U0F7
 
 % Appropriate time representation  "%H:%M:%S"
 t_fmt        "<U0F46><U0F74><U0F0B><U0F5A><U0F7C><U0F51>/
-%   H<U0F40><U0F66><U0F62><U0F0B><U0F58>/
+%H<U0F40><U0F66><U0F62><U0F0B><U0F58>/
 %M<U0F40><U0F66><U0F62><U0F0B><U0F46>%S"
 
 % AM/PM signs


	Jakub
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]