This is the mail archive of the libc-help@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Avoid duplication of _CLOEXEC and _NONBLOCK values


On Sat, Aug 7, 2010 at 6:26 AM, Guy Martin <gmsoft@tuxicoman.be> wrote:
> Remove obsolete files since the _CLOEXEC and _NONBLOCK values don't need
> to be redefined.
> Only sysdeps/unix/sysv/linux/mips/bits/socket.h remains. MIPS seems to be redefining
> SOCK_DGRAM and SOCK_STREAM.
>
> Signed-off-by: Guy Martin <gmsoft@tuxicoman.be>

The idea behind this patch is great, I think we're heading in the
right direction. Before I review the content could you please cleanup
the following and repost?

I'm taking this discussion to libc-help where I can comment on this
without moderation delay or bothering other developers until we finish
working on the patche.

> ---
> ?ChangeLog.alpha ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| ? 10 +
> ?ChangeLog.hppa ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ?5 +
> ?ChangeLog.mips ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ?9 +

Same problem as before, don't inline your ChangeLog differences.

You can just say:

ChanageLog.alpha

[changelog text]

ChangeLog.hppa

[...]

ChangeLog.mips

[...]
~~~
[patch]

etc.

> ?sysdeps/unix/sysv/linux/alpha/bits/socket.h ?| ?431 --------------------------
> ?sysdeps/unix/sysv/linux/alpha/sys/epoll.h ? ?| ?143 ---------
> ?sysdeps/unix/sysv/linux/alpha/sys/eventfd.h ?| ? 52 ---
> ?sysdeps/unix/sysv/linux/alpha/sys/inotify.h ?| ?105 -------
> ?sysdeps/unix/sysv/linux/alpha/sys/signalfd.h | ? 66 ----
> ?sysdeps/unix/sysv/linux/alpha/sys/timerfd.h ?| ? 60 ----
> ?sysdeps/unix/sysv/linux/hppa/bits/socket.h ? | ?409 ------------------------
> ?sysdeps/unix/sysv/linux/mips/sys/epoll.h ? ? | ?144 ---------
> ?sysdeps/unix/sysv/linux/mips/sys/eventfd.h ? | ? 54 ----
> ?sysdeps/unix/sysv/linux/mips/sys/inotify.h ? | ?105 -------
> ?sysdeps/unix/sysv/linux/mips/sys/signalfd.h ?| ? 66 ----
> ?sysdeps/unix/sysv/linux/mips/sys/timerfd.h ? | ? 60 ----
> ?15 files changed, 24 insertions(+), 1695 deletions(-)

Please split this out into 3 different patches. This will allow each
machine maintainer to ack/nack your patch individually instead of
requiring that *all* of them ack/nack in unison.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]