This is the mail archive of the
libc-locales@sourceware.org
mailing list for the GNU libc locales project.
Re: [PATCH] Fix decimal_point and thousands_sep in es_MX locale
On Wed, Jun 06, 2012 at 09:49:24AM -0400, Carlos O'Donell wrote:
> On 6/6/2012 8:32 AM, Aurelien Jarno wrote:
> > On Sun, Jun 03, 2012 at 08:37:06PM -0400, Carlos O'Donell wrote:
> >> On 6/2/2012 3:53 PM, Aurelien Jarno wrote:
> >>> The following patch fixes the value of decimal_point and thousands_sep
> >>> for the es_MX locale, which have been broken by commit 4b19cd7a.
> >>
> >> In the future please provide a more descriptive problem definition.
> >>
> >> For example stating the current character used for the decimal point
> >> and that of the thousands separator, and then stating what you
> >> change them to (along with a verbal definition e.g. "full stop"
> >> for <U002E>) would help the reviewer.
> >>
> >> I know that writing clear and concise problem descriptions is time
> >> consuming, but so is review :-)
> >
> > Sorry about that, after looking for documents it was clear in my mind,
> > and i didn't realize my mail wasn't. Thanks for the review.
>
> No worries. I hope I didn't sound too harsh. I really appreciate your efforts!
>
> >>> Rationale:
> >>> - for decimal_point it's basically reverting to the previous version
> >>> before commit 4b19cd7a.
> >>
> >> OK.
> >>
> >>> - the change is consistent with mon_decimal_point and mon_thousands_sep
> >>> - http://en.wikipedia.org/wiki/Decimal_mark
> >>> - For those speaking Spanish, the official norm is available:
> >>> http://www.ine.gob.mx/publicaciones/download/008scfi.pdf (page 57)
> >>
> >> Spanish is my first language and I read the document.
> >>
> >> Call this [1]
> >>
> >>> amended by:
> >>> http://www.dof.gob.mx/documentos/3837/seeco/seeco.htm
> >>
> >> I also read this document.
> >>
> >> Call this [2]
> >>
> >>> These links shows that it was officially a coma instead of a dot
> >>> starting from 2002, but given that nobody used it, it has been
> >>> switch to coma *or* dot. The dot is the one used in practice.
> >>
> >> Correct, [2] amends [1] and allows comma or full-stop to be used.
> >>
> >>> diff --git a/localedata/ChangeLog b/localedata/ChangeLog
> >>> index 975e59f..a1b5971 100644
> >>> --- a/localedata/ChangeLog
> >>> +++ b/localedata/ChangeLog
> >>> @@ -1,3 +1,8 @@
> >>> +2012-06-02 Aurelien Jarno <aurelien@aurel32.net>
> >>> +
> >>> + * locales/es_MX (LC_NUMERIC): Correctly set decimal_point,
> >>> + thousands_sep and grouping.
> >>> +
> >>> 2012-04-20 Chandan Kumar <chandankumar.093047@gmail.com>
> >>>
> >>> [BZ#13968]
> >>> diff --git a/localedata/locales/es_MX b/localedata/locales/es_MX
> >>> index 7a1cccc..21715b1 100644
> >>> --- a/localedata/locales/es_MX
> >>> +++ b/localedata/locales/es_MX
> >>> @@ -78,7 +78,9 @@ n_sign_posn 1
> >>> END LC_MONETARY
> >>>
> >>> LC_NUMERIC
> >>> -copy "es_ES"
> >>> +decimal_point "<U002E>"
> >>
> >> This is OK.
> >>
> >>> +thousands_sep "<U002C>"
> >>
> >> This is not correct (and it was previously not correct either).
> >>
> >> According to [2] this must be a "small space" (pequeño espacio), and must never be a comma, point, or other symbol.
> >>
> >> There is a `thin space' <U+2009> which probably serves the best purpose here.
> >
> > Yes, it should be a thin space, it's actually what the SI/ISO 31-0
> > standards specifies. That said a lot of other languages are following
> > this standard and are supposed to use a thin space there (for example
> > fr_FR), but are using a normal space (<U0020>) there.
> >
> > I realized my intention was to put <U0020> there instead. Is it
> > something acceptable?
>
> Sorry, I'm a bit confused.
>
> Why can't we use thin space?
Probably we can. I am just confused that all the locales that are
supposed to do that are not doing it, so there might be a reason behind
that.
> >> What do other OSs do?
> >>
> >
> > Windows XP is using a comma (<U002C>) there.
>
> Which is wrong according to the standard.
>
Agreed. OTOH Windows XP is very old.
Cheers,
Aurelien
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net