On Wed, May 10, 2006 at 12:20:29PM -0700, Khem Raj wrote:
Hi
This patch is to let linuxthreads compile in glibc 2.4
Without this patch it fails with following error.
In file included from libc-cancellation.c:24:
spinlock.h:175: error: expected identifier or '(' before '{' token
spinlock.h:187: error: expected identifier or '(' before '{' token
make[2]: ***
[/home/build/BUILD/glibc-2.4.90/objdir-linuxthreads_64/linuxthreads/libc-cancellation.o]
Error 1
This is because atomic_increment and atomic_decrement are already
defined in sysdeps/powerpc/bits/atomic.h
and here there get replace the definitions in linuxthreads/spinlock.h
and cause the above error
Is this ok?
Um, no.
/* Operations on pthread_atomic, which is defined in internals.h */
static inline long atomic_increment(struct pthread_atomic *pa)
The two atomic_increment implementations aren't quite similar enough.
The LinuxThreads version should just be renamed. Try the attached,
please.