This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][RFC] Fix MIPS struct sigcontext redefinition

From: Mike Frysinger <vapier at gentoo dot org>
To: libc-ports at sourceware dot org
Cc: Hiroki Kaminaga <kaminaga at sm dot sony dot co dot jp>
Date: Fri, 22 Dec 2006 02:53:12 -0500
Subject: Re: [PATCH][RFC] Fix MIPS struct sigcontext redefinition
Organization: wh0rd.org
References: <20061222.105000.85683011.kaminaga@sm.sony.co.jp>

On Thursday 21 December 2006 20:50, Hiroki Kaminaga wrote:
> #include <asm/sigcontext.h>

this is your problem ... mixing userspace and kernel headers

> Below is the patch to fix the problem. Is this patch fine?
> _ASM_SIGCONTEXT_H was defined in glibc-2.3.6, and I mimiced that.

it'd make more sense to wrap the entire file in 1 #ifndef...#define..#endif 
rather than each individual section

that said, i really dont think your fix is correct as you're ignoring the 
fundamental problem of mixing userspace and kernelspace headers
-mike

Attachment: pgp00000.pgp
Description: PGP signature

References:
- [PATCH][RFC] Fix MIPS struct sigcontext redefinition
  - From: Hiroki Kaminaga

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]