This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix mips N32 build


On Sat, Mar 29, 2008 at 12:24:57AM +0100, Aurelien Jarno wrote:
> The patch below is needed for a mips N32 build of the glibc.
> 
> 2008-03-15  Aurelien Jarno  <aurelien@aurel32.net>
> 
> 	* sysdeps/unix/sysv/linux/mips/mips64/n32/ftruncate64.c: Drop ftruncate
> 	declaration.
> 
> 2008-01-24  Aurelien Jarno  <aurelien@aurel32.net>
> 
> 	* sysdeps/unix/sysv/linux/mips/mips64/n32/truncate64.c: Drop truncate
> 	declaration.
> 	(truncate64): Fix arguments and call to truncate.

Doesn't this make them simply aliases for the normal functions?  I
would be surprised if ftruncate and ftruncate64 on n32 have the same
type for the second argument.

If the second argument is only an off_t this risks the compiler
dropping the top half.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]