This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Directory for localplt / c++-types data
- From: Daniel Jacobowitz <drow at false dot org>
- To: Roland McGrath <roland at redhat dot com>, libc-ports at sourceware dot org
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Mon, 18 Aug 2008 08:43:14 -0400
- Subject: Re: Directory for localplt / c++-types data
- References: <20080718134710.GB11085@caradoc.them.org>
On Fri, Jul 18, 2008 at 09:47:10AM -0400, Daniel Jacobowitz wrote:
> Hi Roland,
>
> What do you think of this patch? The data files have long names;
> having them in the top level of the ports add-on would be ugly, and
> there's a precedent (the "sysdeps" subdir).
>
> On a related note, if Joseph's agreeable, I'd like to suggest him as a
> ports maintainer or at least write-after-approval. Basically the only
> thing I've done on ports in a year is commit Joseph's patches
> (usually late).
Hi Roland,
Did you see this patch / question?
> 2008-07-18 Daniel Jacobowitz <dan@codesourcery.com>
>
> * Makefile (check-data): Check data directory in add-ons.
> * elf/Makefile (check-data): Likewise.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/glibc/libc/Makefile,v
> retrieving revision 1.255
> diff -u -p -r1.255 Makefile
> --- Makefile 22 May 2008 00:03:43 -0000 1.255
> +++ Makefile 18 Jul 2008 13:43:49 -0000
> @@ -247,8 +247,8 @@ tests-clean:
> tests: $(objpfx)c++-types-check.out $(objpfx)check-local-headers.out
> ifneq ($(CXX),no)
> check-data := $(firstword $(wildcard \
> - $(foreach D,$(add-ons) scripts/data,\
> - $(patsubst %,$D/c++-types-%.data,\
> + $(foreach D,$(add-ons) scripts,\
> + $(patsubst %,$D/data/c++-types-%.data,\
> $(abi-name) \
> $(addsuffix -$(config-os),\
> $(config-machine) \
> Index: elf/Makefile
> ===================================================================
> RCS file: /cvs/glibc/libc/elf/Makefile,v
> retrieving revision 1.325
> diff -u -p -r1.325 Makefile
> --- elf/Makefile 22 May 2008 00:03:43 -0000 1.325
> +++ elf/Makefile 18 Jul 2008 13:43:50 -0000
> @@ -841,8 +841,8 @@ $(objpfx)tst-dlmodcount: $(libdl)
> $(objpfx)tst-dlmodcount.out: $(test-modules)
>
> check-data := $(firstword $(wildcard \
> - $(foreach D,$(add-ons) scripts/data,\
> - $(patsubst %,$(..)$D/localplt-%.data,\
> + $(foreach D,$(add-ons) scripts,\
> + $(patsubst %,$(..)$D/data/localplt-%.data,\
> $(abi-name) \
> $(addsuffix -$(config-os),\
> $(config-machine) \
>
--
Daniel Jacobowitz
CodeSourcery