This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] Fix SOCK_CLOEXEC on HPPA to match O_CLOEXEC
On Tue, Feb 16, 2010 at 8:46 AM, Carlos O'Donell
<carlos@systemhalted.org> wrote:
>> --- a/ChangeLog.hppa
>> +++ b/ChangeLog.hppa
>> @@ -1,3 +1,8 @@
>> +2010-02-12 ?Matt Turner ?<mattst88@gmail.com>
>> +
>> + ? ? ? * sysdeps/unix/sysv/linux/hppa/bits/socket.h: Actually fix
>> + ? ? ? SOCK_CLOEXEC to match O_CLOEXEC.
>> +
>
> Thanks for the patch!
>
>> ?2010-02-01 ?Kyle McMartin ?<kyle@redhat.com>
>>
>> ? ? ? ?* sysdeps/unix/sysv/linux/hppa/bits/socket.h: Fix value of
>> diff --git a/sysdeps/unix/sysv/linux/hppa/bits/socket.h b/sysdeps/unix/sysv/linux/hppa/bits/socket.h
>> index bcc27cc..819b398 100644
>> --- a/sysdeps/unix/sysv/linux/hppa/bits/socket.h
>> +++ b/sysdeps/unix/sysv/linux/hppa/bits/socket.h
>> @@ -62,7 +62,7 @@ enum __socket_type
>> ? /* Flags to be ORed into the type parameter of socket and socketpair and
>> ? ? ?used for the flags parameter of paccept. ?*/
>>
>> - ?SOCK_CLOEXEC = 01000000, ? ? /* Atomically set close-on-exec flag for the
>> + ?SOCK_CLOEXEC = 010000000, ? ?/* Atomically set close-on-exec flag for the
>> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? new descriptor(s). ?*/
>> ?#define SOCK_CLOEXEC SOCK_CLOEXEC
>> ?#undef SOCK_NONBLOCK
>
> Kyle, please comment?
Kyle responded to me privately indicating that your patch is correct.
Applied.
Thanks Matt, please check the git commit to see if everything was in order.
Cheers,
Carlos.