Re: [PATCH] Fix SOCK_CLOEXEC on HPPA to match O_CLOEXEC

[Jim Meyering <jim at meyering dot net>]

Carlos O'Donell wrote:
> On Tue, Feb 16, 2010 at 3:12 PM, Matt Turner <mattst88@gmail.com> wrote:
>> Do other people not do this? Looks like all my patches that Joseph has
>> committed are attributed to me in git. I don't see anything committed
>> to glibc.git by anyone other than Ulrich Drepper, but plenty of
>> authors.
>
> It sounds like this is common practice then. Thanks.
>
> I'll document this on the glibc wiki.
>
> What ways other than `git am` and `git commit --author=` are there to
> indicate the true author of the patch?

If you commit it locally with yourself as the author
when in fact someone else should be listed as the author,
you can change it with this:

    git commit --amend --author='Some Other User <user@example.com>'

Here are a few personal guidelines I follow in projects I own:

Even if I make some (but not "sweeping") changes, I generally leave the
original author's name as commit "Author".  However, when amending it's
important to be very sure of what you're doing, and usually good to get
sign-off from the contributor.  It's not pleasant to "adjust" a patch
incorrectly and then to commit/push the bug (to a non-rewindable branch)
in the name of someone else.

Likewise, on the giving-credit front, when I post a patch for review,
and someone spots a bug in it, I've begun to add an "Improved by: ..."
line to give them credit for that.