This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] Fix the glibc profiling issue on arm-unknown-linux-gnueabi.
Hi Joseph,
>
> I can only review a patch for the current sources. ?Once there is a
> suitable version in there, if you wish to propose backports for previous
> release branches you can do so.
>
This time I have created the patch with the following sources
glibc-2.12.2 and glibc-ports 2.12.2
I have even tested it on ARMv7a (Beagle Board) and hope this would be
fine to be main lined.
{{{
--- a/glibc-ports-2.12.2/sysdeps/arm/sysdep.h 2011-01-26
02:30:16.000000000 +0530
+++ b/glibc-ports-2.12.2/sysdeps/arm/sysdep.h 2011-01-31
16:00:10.000000000 +0530
@@ -18,6 +18,7 @@
02111-1307 USA. */
#include <sysdeps/generic/sysdep.h>
+#include <features.h>
#if (!defined (__ARM_ARCH_2__) && !defined (__ARM_ARCH_3__) \
&& !defined (__ARM_ARCH_3M__) && !defined (__ARM_ARCH_4__))
@@ -92,6 +93,14 @@
/* If compiled for profiling, call `mcount' at the start of each function. */
#ifdef PROF
+/* Call __gnu_mcount_nc if GCC > 4.4 and abi = EABI */
+#if __GNUC_PREREQ(4,4) && defined(__ARM_EABI__)
+#define CALL_MCOUNT \
+ str lr,[sp, #-4]!; \
+ cfi_adjust_cfa_offset (4); \
+ cfi_rel_offset (lr, 0); \
+ bl PLTJMP(mcount);
+#else /* else call _mcount */
#define CALL_MCOUNT \
str lr,[sp, #-4]!; \
cfi_adjust_cfa_offset (4); \
@@ -100,6 +109,7 @@
ldr lr, [sp], #4; \
cfi_adjust_cfa_offset (-4); \
cfi_restore (lr)
+#endif
#else
#define CALL_MCOUNT /* Do nothing. */
#endif
@@ -109,8 +119,12 @@
on this system, the asm identifier `syscall_error' intrudes on the
C name space. Make sure we use an innocuous name. */
#define syscall_error __syscall_error
+#if __GNUC_PREREQ(4,4) && defined(__ARM_EABI__)
+#define mcount __gnu_mcount_nc
+#else
#define mcount _mcount
#endif
+#endif
#if defined(__ARM_EABI__)
/* Tag_ABI_align8_preserved: This code preserves 8-byte
}}}
> Joseph S. Myers
> joseph@codesourcery.com
>
Thanks for your time and support.
Regards,
Manjunath S Matti
Sony India Software Centre.