This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Restore ARM profil_counter export (bug 14043)


Given the various recent bugs other people have been finding in ABI 
testing and baselines, it seemed a good idea to check the ARM and MIPS ABI 
baselines I added against various binaries of previous release / release 
branch versions I had around.  These are patched versions rather than 
unmodified releases and don't cover all relevant releases, so it's not a 
perfect test, but it showed up that the symbol profil_counter, formerly 
exported by ARM glibc at version GLIBC_2.4, had disappeared as a result of 
<http://sourceware.org/ml/libc-ports/2007-12/msg00008.html> (changing the 
ARM profil-counter.h, in which profil_counter was not static, to use the 
x86 version, in which it is static).  I've applied this patch to restore 
the export, by using a copy of the x86 header without "static", and update 
the ABI baseline accordingly.

The other ABI issue I saw in ARM comparisons was that the libresolv 
variable __p_type_syms changed size from 0x21c to 0x228 (and on 64-bit 
platforms, from 0x438 to 0x450), probably as a result of

2008-06-26  Ulrich Drepper  <drepper@redhat.com>

        * resolv/res_debug.c (__p_type_syms): Add ns_t_dname entry.
        Patch by Peter Jones <pjones@redhat.com>.

but since there have been releases with both the old and the new sizes at 
the same symbol version, I don't think there's anything we can now do 
about that breakage.  (I don't know why this is a public symbol anyway.)

diff --git a/ChangeLog.arm b/ChangeLog.arm
index facddbb..cdbed7b 100644
--- a/ChangeLog.arm
+++ b/ChangeLog.arm
@@ -1,3 +1,11 @@
+2012-05-01  Joseph Myers  <joseph@codesourcery.com>
+
+	[BZ #14043]
+	* sysdeps/unix/sysv/linux/arm/profil-counter.h: New file.  Based
+	on i386 version but without "static".
+	* sysdeps/unix/sysv/linux/arm/nptl/libc.abilist (GLIBC_2.4): Add
+	profil_counter.
+
 2012-04-28  Joseph Myers  <joseph@codesourcery.com>
 
 	[BZ #13986]
diff --git a/sysdeps/unix/sysv/linux/arm/nptl/libc.abilist b/sysdeps/unix/sysv/linux/arm/nptl/libc.abilist
index 1f25c37..6322dcf 100644
--- a/sysdeps/unix/sysv/linux/arm/nptl/libc.abilist
+++ b/sysdeps/unix/sysv/linux/arm/nptl/libc.abilist
@@ -1421,6 +1421,7 @@ GLIBC_2.4
  printf_size F
  printf_size_info F
  profil F
+ profil_counter F
  program_invocation_name D 0x4
  program_invocation_short_name D 0x4
  pselect F
diff --git a/sysdeps/unix/sysv/linux/arm/profil-counter.h b/sysdeps/unix/sysv/linux/arm/profil-counter.h
index 8a6a0bc..f305674 100644
--- a/sysdeps/unix/sysv/linux/arm/profil-counter.h
+++ b/sysdeps/unix/sysv/linux/arm/profil-counter.h
@@ -1,2 +1,31 @@
-/* We can use the ix86 version.  */
-#include <sysdeps/unix/sysv/linux/i386/profil-counter.h>
+/* Low-level statistical profiling support function.  Linux/ARM version.
+   Copyright (C) 1996-2012 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <signal.h>
+#include <sigcontextinfo.h>
+
+void
+profil_counter (int signo, const SIGCONTEXT scp)
+{
+  profil_count ((void *) GET_PC (scp));
+
+  /* This is a hack to prevent the compiler from implementing the
+     above function call as a sibcall.  The sibcall would overwrite
+     the signal context.  */
+  asm volatile ("");
+}

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]