This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH 1/3, MIPS] Rewrite MIPS' atomic.h to use __atomic_* builtins.
On Thu, 28 Jun 2012, Maxim Kuvyrkov wrote:
> Here is an updated patch fixed per above comments.
This is OK for 2.17 (that is, for the ports subdirectory in the libc
repository once that merge has been done, reviewed and is on master and
the commit moratorium has been explicitly lifted), with the following
change.
> +/* ??? Barrier semantics for atomic_exchange_and_add appear to be
> + undefined. Use full barrier for now, as that's safe. */
Please file a bug to clarify these semantics, if not already filed, and
reference it in the comment. (Clarifying the semantics will I suppose
involve examining both direct and indirect users of
atomic_exchange_and_add to work out what they need and whether it should
be split into multiple macros with different barrier semantics.)
--
Joseph S. Myers
joseph@codesourcery.com