This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH roland/arm-irel-ldsodefs] ARM: add missing #include
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Wed, 8 Aug 2012 20:34:14 +0000
- Subject: Re: [PATCH roland/arm-irel-ldsodefs] ARM: add missing #include
- References: <20120808201918.7E2932C083@topped-with-meat.com>
On Wed, 8 Aug 2012, Roland McGrath wrote:
> I'm doing a cross-build for arm-linux-gnueabi with trunk GCC.
> There's an early error from a missing definition of GLRO.
> I don't know how the build could be working for anybody without
> this fix, but maybe there is some indirect difference caused by
> the compiler.
>
> Ok to commit (i.e. merge roland/arm-irel-ldsodefs)?
It's OK and adding missing #includes is one of the types of changes
documented at <http://sourceware.org/glibc/wiki/Consensus> as not needing
review, but what source file are you building to get this error and what
header include order do you see when that file is built? It looks like
(as indicated e.g. by the ordering in the .d files) all the files that end
up including dl-irel.h get ldsodefs.h included first for me.
--
Joseph S. Myers
joseph@codesourcery.com