This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Ping ia64 Re: Move Linux kernel version conditionals to kernel-features.h
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: <libc-ports at sourceware dot org>
- Cc: Mike Frysinger <vapier at gentoo dot org>
- Date: Thu, 9 Aug 2012 23:37:00 +0000
- Subject: Ping ia64 Re: Move Linux kernel version conditionals to kernel-features.h
- References: <Pine.LNX.4.64.1208031505380.25698@digraph.polyomino.org.uk>
On Fri, 3 Aug 2012, Joseph S. Myers wrote:
> Generally conditions on the compile-time minimum Linux kernel version
> go via __ASSUME_* macros defined in kernel-features.h. However,
> sysdeps/unix/sysv/linux/sysconf.c and
> ports/sysdeps/unix/sysv/linux/ia64/nptl/dl-sysdep.h have such
> conditions directly using __LINUX_KERNEL_VERSION.
>
> This patch fixes those conditions to follow the kernel-features.h
> convention instead. For sysconf.c, a new macro
> __ASSUME_ARG_MAX_STACK_BASED is defined and used. Because the #if
> condition was a condition on an if () condition using the same
> version, the same version number was previously repeated in both
> conditions in close proximity; to avoid those copies (that should be
> in sync) now being widely separated, I defined a macro
> __LINUX_ARG_MAX_STACK_BASED_MIN_KERNEL for the version number in
> question. For ports/sysdeps/unix/sysv/linux/ia64/nptl/dl-sysdep.h, I
> removed the condition; this is in line with commit
> de7f5ce7c595f4741029f7e63429826f8e82b340 which removed such a
> condition from nptl/sysdeps/unix/sysv/linux/i386/i686/dl-sysdep.h a
> few months ago.
>
> Tested x86_64. (This should be reviewed for ia64.)
Ping. This patch
<http://sourceware.org/ml/libc-ports/2012-08/msg00028.html> is pending
ia64 review.
--
Joseph S. Myers
joseph@codesourcery.com