This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] AArch64 optimized memset
On Wed, 16 Jan 2013, Marcus Shawcroft wrote:
> This patch provides an AArch64 optimzied memset implementation.
You have two macros DONT_USE_DC and MAYBE_VIRT in this code, but no
configure options to set them. It seems unfortunate if a libc configured
with the default configuration is unsuitable for virtualized environments,
for example. Shouldn't you have appropriate ways to configure these
things, documented in the installation manual, with safe defaults if the
user doesn't use any special options? (The default could use IFUNC to
select between different versions based on the system being used, I
suppose.)
Is the caching definitely safe if multiple threads on different processors
are executing the code using the cache at the same time?
--
Joseph S. Myers
joseph@codesourcery.com