This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH][BZ #15054] MIPS: Fix syscall wrappers for syscall restart support
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Wed, 23 Jan 2013 17:06:23 +0000
- Subject: Re: [PATCH][BZ #15054] MIPS: Fix syscall wrappers for syscall restart support
- References: <alpine.DEB.1.10.1301230241530.4834@tp.orcam.me.uk>
On Wed, 23 Jan 2013, Maciej W. Rozycki wrote:
> +#ifdef __mips_micromips
> +#define MOVE32 "move32"
> +#else
> +#define MOVE32 "move"
> +#endif
Indent preprocessor directives inside #if, so "# define", here and in the
other instances of this code in the patch.
> + register long __s0 asm("$16") __attribute__((unused)) = number; \
Space between __attribute__ and ((unused)), everywhere this construct
appears in this patch.
OK with those whitespace fixes; remember to update the list of fixed bugs
in the NEWS file (a single list is used for both libc and ports bugs) as
part of your commit of the fix, and to close the bug as fixed afterwards.
--
Joseph S. Myers
joseph@codesourcery.com