This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] MIPS: MIPS16 support


On Wed, 20 Feb 2013, Maciej W. Rozycki wrote:

> 	* sysdeps/mips/fpu_control.h (__fpu_getcw) [__mips16]: New
> 	prototype.
> 	(__fpu_setcw) [__mips16]: Likewise.

Since you've renamed the functions to __mips_fpu_getcw and 
__mips_fpu_setcw, you need to update the ChangeLog entry accordingly.  
The ChangeLog entries may also need updates for other changes in this 
patch version.

> 	* sysdeps/mips/mips32/mips16/fpu/Versions: New file.

Actually you moved the Versions file to the correct place for the symbol 
versions not to depend on whether glibc itself is built as MIPS16.  But 
the contents of the file - and of the libc.abilist changes - need updating 
for the new symbol names.

(Given these inconsistencies, I haven't fully reviewed the rest of the 
patch contents.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]