This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Usage of __attribute__used__ in (system) headers?


On 02/20/2013 12:56 PM, Thomas Schwinge wrote:
> Hi!
> 
> On Wed, 20 Feb 2013 11:25:22 -0500, Carlos O'Donell <carlos@redhat.com> wrote:
>>>  static union { unsigned char __c[4]; float __d; } __nan_union
>>> -    __attribute_used__ = { __nan_bytes };
>>> +  __attribute__ ((unused)) = { __nan_bytes };
> 
>> Please fix this to use __unused__.
>>
>> We should not use attributes that are in the user's namespace.
> 
> Pushed as commit 50022a93fcc36a0130b9f882709ff69f4b91c0cc:
> 
> 	* sysdeps/ieee754/bits/nan.h [!__GNUC__] (__nan_union): Change
> 	__attribute__ ((unused)) to __attribute__ ((__unused__)).
> 
> ports/
> 	* sysdeps/mips/bits/nan.h [!__GNUC__] (__nan_union): Change
> 	__attribute__ ((unused)) to __attribute__ ((__unused__)).

Thanks!

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]