This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH 05/26] arm: Introduce thumb helpers s and pc_ofs
Richard Henderson <rth@twiddle.net> writes:
> On 2013-02-27 16:20, Joseph S. Myers wrote:
>>> * sysdeps/arm/sysdep.h (s, pc_ofs): New macros.
>> Other assembler syntax macros have names in uppercase, and a single
>> character seems too short for a macro name to me.
>
> I simply found that "s(and)" is easy to read, and it looks close to
> "ands" to which it expands. I'd rather drop this change, and all uses
> thereof, than make the code less readable.
How many places is it used? From what I can tell, the only purpose is
to enable use of the 16-bit thumb encoding, so if it's used in just a
few places, the savings might not be worth the obfuscation.
--
Måns Rullgård
mans@mansr.com