This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH roland/arm-unified] ARM: Convert string/ assembly to unified syntax.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, libc-ports at sourceware dot org
- Date: Mon, 11 Mar 2013 17:19:26 -0400
- Subject: Re: [PATCH roland/arm-unified] ARM: Convert string/ assembly to unified syntax.
- References: <20130311182236.CAA382C071@topped-with-meat.com>
On 03/11/2013 02:22 PM, Roland McGrath wrote:
> The assemblers I'm using give warnings about some code being in the older
> syntax. This makes them happy. Verified that the assembled instructions
> are unchanged.
>
> OK?
>
>
> Thanks,
> Roland
>
>
> ports/ChangeLog.arm
> * sysdeps/arm/memcpy.S: Convert to unified assembly syntax.
> * sysdeps/arm/memmove.S: Likewise.
> * sysdeps/arm/memset.S: Likewise.
> * sysdeps/arm/strlen.S: Likewise.
>
> --- a/ports/sysdeps/arm/memcpy.S
> +++ b/ports/sysdeps/arm/memcpy.S
> @@ -53,6 +53,7 @@
> #endif
>
> .text
> + .syntax unified
All new code should really be using the unified syntax, I'm happy
to see this change, and a quick check against my quick reference
for unified syntax passes OK.
When you verified the assembled instructions were unchanged did
you look to see that the opcodes were the same or that disassembling
the result yielded the same previously disassembled instructions?
I say this just to make sure we didn't happen across any binutils
bugs, which isn't uncommon in some of the less used encodings, or
that the encodings changed and that they mean something else now.
Cheers,
Carlos.