This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH roland/arm-avoid-pc] ARM: Support avoiding pc as destination register.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Tue, 12 Mar 2013 23:35:25 +0000
- Subject: Re: [PATCH roland/arm-avoid-pc] ARM: Support avoiding pc as destination register.
- References: <20130311205410.2A99B2C08D@topped-with-meat.com>
On Mon, 11 Mar 2013, Roland McGrath wrote:
> * sysdeps/arm/arm-features.h: Add comment about ARM_ALWAYS_BX.
That's OK.
> +#else
> + beq 7f
> + push {r10}
> + cfi_adjust_cfa_offset (4)
This should also have cfi_rel_offset (r10, 0) to record the save itself in
CFI debug information.
> +#ifdef ARM_ALWAYS_BX
> + pop {r10}
> + cfi_adjust_cfa_offset (-4)
> +#endif
Likewise, record the restore of r10.
> +#else
> + beq 7f
> + push {r10}
> + cfi_adjust_cfa_offset (4)
Likewise, in memmove.
> +#ifdef ARM_ALWAYS_BX
> + pop {r10}
> + cfi_adjust_cfa_offset (-4)
Likewise.
--
Joseph S. Myers
joseph@codesourcery.com