This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH, v6] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC.
- From: Will Newton <will dot newton at linaro dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-ports at sourceware dot org, Patch Tracking <patches at linaro dot org>
- Date: Wed, 8 May 2013 10:43:30 +0100
- Subject: Re: [PATCH, v6] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC.
- References: <518171B2 dot 5020504 at linaro dot org> <Pine dot LNX dot 4 dot 64 dot 1305032015060 dot 30366 at digraph dot polyomino dot org dot uk> <CANu=DmgtiwoNj70FjJWKkP43wLqf=KuAyeS1sVC6-sKw7_E7HA at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1305041312390 dot 658 at digraph dot polyomino dot org dot uk>
On 4 May 2013 14:13, Joseph S. Myers <joseph@codesourcery.com> wrote:
Hi Joseph,
> On Fri, 3 May 2013, Will Newton wrote:
>
>> On 3 May 2013 21:18, Joseph S. Myers <joseph@codesourcery.com> wrote:
>>
>> Hi Joseph,
>>
>> >> This was tested on armv7l-unknown-linux-gnueabihf. One new testsuite
>> >
>> > I think string functions also need big-endian testing (which should be
>> > possible with userspace QEMU - you should be able to run the string tests
>> > that way, though not the whole testsuite). If such testing passes, this
>> > version is OK (though as Roland notes there's scope for further
>> > optimization in the __ARM_NEON__ case).
>>
>> I have tested the same code using a big-endian qemu with the
>> cortex-strings tests which are taken from glibc:
>>
>> http://bazaar.launchpad.net/~linaro-toolchain-dev/cortex-strings/trunk/view/head:/tests/test-memcpy.c
>>
>> I haven't built glibc big-endian yet, but I can do that if you think
>> it would be valuable.
>
> Yes, I believe this should be tested with the current glibc string tests
> for a big-endian build of glibc.
I can confirm test-memcpy and test-memcpy-ifunc both pass under big endian qemu.
--
Will Newton
Toolchain Working Group, Linaro