This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] ARM: Fix clone code when built for Thumb.
- From: Will Newton <will dot newton at linaro dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Thu, 29 Aug 2013 21:19:10 +0100
- Subject: Re: [PATCH] ARM: Fix clone code when built for Thumb.
- Authentication-results: sourceware.org; auth=none
- References: <521F9E4E dot 5040906 at linaro dot org> <Pine dot LNX dot 4 dot 64 dot 1308291924210 dot 1487 at digraph dot polyomino dot org dot uk>
On 29 August 2013 20:26, Joseph S. Myers <joseph@codesourcery.com> wrote:
Hi Joseph,
>> The mov lr, pc instruction will lose the Thumb bit from the return address
>> so use blx lr instead.
>>
>> ports/ChangeLog.arm:
>>
>> 2013-08-29 Will Newton <will.newton@linaro.org>
>>
>> * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
>> instead of mov lr, pc.
>
> OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and
> addition of the fixed bug number to NEWS. Since this is a regression
> arising from the changes to build .S files as Thumb, you should also
> cherry-pick the fix to 2.18 branch.
I've filed a bug and posted a v2. I don't have commit access so I'm
not sure what the best way to facilitate the cherry pick is. Apart
from the NEWS entry the merge should be trivial.
--
Will Newton
Toolchain Working Group, Linaro