This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] ARM: Fix clone code when built for Thumb.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Fri, 30 Aug 2013 13:35:05 -0400
- Subject: Re: [PATCH] ARM: Fix clone code when built for Thumb.
- Authentication-results: sourceware.org; auth=none
- References: <521F9E4E dot 5040906 at linaro dot org> <Pine dot LNX dot 4 dot 64 dot 1308291924210 dot 1487 at digraph dot polyomino dot org dot uk> <CANu=Dmg_ry0d5eJcRJ+iw0NVRHPamq2G8kGPwguxqSVUSRqaTQ at mail dot gmail dot com>
On 08/30/2013 06:18 AM, Will Newton wrote:
> On 29 August 2013 20:26, Joseph S. Myers <joseph@codesourcery.com> wrote:
>> On Thu, 29 Aug 2013, Will Newton wrote:
>>
>>> The mov lr, pc instruction will lose the Thumb bit from the return address
>>> so use blx lr instead.
>>>
>>> ports/ChangeLog.arm:
>>>
>>> 2013-08-29 Will Newton <will.newton@linaro.org>
>>>
>>> * sysdeps/unix/sysv/linux/arm/clone.S (__clone): Use blx
>>> instead of mov lr, pc.
>>
>> OK given a bug filed in Bugzilla and appropriate [BZ #N] notation and
>> addition of the fixed bug number to NEWS. Since this is a regression
>> arising from the changes to build .S files as Thumb, you should also
>> cherry-pick the fix to 2.18 branch.
>
> Committed to master and the 2.18 branch. Let me know if I missed anything.
Please be aware that the release manager for 2.18 should be ACK'ing your
patches going into 2.18 (David Miller). David is responsible for the
branch and it's his responsibility if the branch gets into a bad state.
You can make it easy for David by stating that Joseph said it's OK, and
explaining your testing.
Cheers,
Carlos.