This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [patch, mips] Improved memset for MIPS
- From: Steve Ellcey <sellcey at mips dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Fri, 6 Sep 2013 09:50:41 -0700
- Subject: Re: [patch, mips] Improved memset for MIPS
- Authentication-results: sourceware.org; auth=none
- References: <93a232b5-9d0b-4a27-bbb5-16e3ae7c4b89 at BAMAIL02 dot ba dot imgtec dot org> <Pine dot LNX dot 4 dot 64 dot 1309061430150 dot 5886 at digraph dot polyomino dot org dot uk> <1378483039 dot 5770 dot 302 dot camel at ubuntu-sellcey> <Pine dot LNX dot 4 dot 64 dot 1309061603380 dot 8532 at digraph dot polyomino dot org dot uk>
On Fri, 2013-09-06 at 16:09 +0000, Joseph S. Myers wrote:
> > No. I did most of my testing outside of the glibc testsuite because I
> > find the glibc testsuite difficult to run, see
> > https://sourceware.org/ml/libc-help/2013-08/msg00040.html for some of my
> > problems/questions. I don't believe I have ever managed to do a clean
>
> You'll need to debug the problems as they indicate something wrong with
> your build environment. It's always advised to configure glibc with
> --prefix=/usr rather than some other prefix (but there is no requirement
> that the dynamic linker actually be installed during testing, you can
> ignore the -dynamic-linker= path), and your other error indicates some
> inconsistency regarding NO_CTORS_DTORS_SECTIONS.
I have found that --prefix=/usr is more of a problem then a help when
building general cross compiler toolchains. Using a prefix of /usr
triggers various special case code in
ports/sysdeps/unix/sysv/linux/mips/configure to put things in lib32 and
lib64 and I don't actually want any of that so I use a prefix
of /usr/fake instead of /usr.
The "undefined reference to `__libc_global_ctors'" has just shown up
again in a parallel build, but it seems to go away when I rebuild. I am
still trying to understand what is going on with this.
> The expectation is that the glibc testsuite is the normal way to test
> patches before submission, and string function patches like this need it
> to be run for all six relevant ABI variants.
I think some flexibility here would be better. There is no floating
point code in this routine so running all three ABI's in both hard and
soft float modes seems like overkill to me. Testing in big and little
endian modes would seem more likely to turn up problems then testing in
hard and soft float.
Steve Ellcey
sellcey@imgtec.com